Summary: | [ninja] Don't remove response files for verbose builds | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||||
Component: | Tools / Tests | Assignee: | Éva Balázsfalvi <evab.u-szeged> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cgarcia, commit-queue, dbates, evab.u-szeged, gyuyoung.kim, mrobinson | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2014-10-17 06:03:03 PDT
Response file are necessary because CMake + Ninja does not know how to add files to ar archives in chunks. Instead it will try to add them using one command invocation. Created attachment 240601 [details]
Patch
"-d keeprsp" is available since ninja version 1.4.0, so created the feature according to this.
Created attachment 240602 [details]
Patch
Created attachment 240603 [details]
Patch
Ping? Comment on attachment 240603 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240603&action=review The idea is good, but I suggest some minor style changes. > Tools/Scripts/webkitdirs.pm:170 > + my $ninjaVersion = `ninja --version`; > + $ninjaVersion =~ s/\R//g; I think chomp is better choice here: chomp(my $ninjaVersion = `ninja --version`); > Tools/Scripts/webkitdirs.pm:1841 > + > + if (version->parse(determineNinjaVersion()) >= version->parse("1.4.0")) { > + push @args, "-d keeprsp"; > + } We can do it in one line: push @args, "-d keeprsp" if (version->parse(determineNinjaVersion()) >= version->parse("1.4.0")); Created attachment 240834 [details]
Patch for landing
Comment on attachment 240834 [details] Patch for landing Clearing flags on attachment: 240834 Committed r175469: <http://trac.webkit.org/changeset/175469> All reviewed patches have been landed. Closing bug. |