Bug 137739

Summary: [GTK]FindHarfBuzz.cmake dose not handle harfbuzz-icu correctly
Product: WebKit Reporter: 宋文武 <iyzsong>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex_y_xu, berto, bugs-noreply, cgarcia, mcatanzaro, zan
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
cmake: finding harfbuzz-icu none

宋文武
Reported 2014-10-15 06:12:01 PDT
Suppose I have harfbuzz and harfbuzz-icu install to two different directories, then paths to hb.h and hb-icu.h should both included in HARFBUZZ_INCLUDE_DIRS. And the ``list APPEND`` method does not really work. Here is a patch I used to package it for NixOS. Version: webkitgtk-2.6.1
Attachments
cmake: finding harfbuzz-icu (112 bytes, text/plain)
2014-10-15 06:14 PDT, 宋文武 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
宋文武
Comment 1 2014-10-15 06:14:11 PDT
Created attachment 239870 [details] cmake: finding harfbuzz-icu
Alberto Garcia
Comment 2 2014-12-07 10:46:06 PST
Why don't you (In reply to comment #0) > Suppose I have harfbuzz and harfbuzz-icu install to two different > directories, > then paths to hb.h and hb-icu.h should both included in > HARFBUZZ_INCLUDE_DIRS. I'm not a cmake expert, but why don't you look for hb.h in the new patch then? In the HarfBuff >= 0.9.18 branch of the if I only see hb-icu.h.
宋文武
Comment 3 2014-12-08 18:20:13 PST
(In reply to comment #2) > Why don't you (In reply to comment #0) > > Suppose I have harfbuzz and harfbuzz-icu install to two different > > directories, > > > then paths to hb.h and hb-icu.h should both included in > > HARFBUZZ_INCLUDE_DIRS. > > I'm not a cmake expert, but why don't you look for hb.h in the new patch > then? Obvious, I'm not a cmake expert too :) Ah yes, It's good to add a find_path for hb.h too. Even pkg_check_modules(PC_HARFBUZZ harfbuzz>=0.9.7) should given a corret PC_HARFBUZZ_INCLUDE_DIRS (having hb.h). > In the HarfBuff >= 0.9.18 branch of the if I only see hb-icu.h.
alex_y_xu
Comment 4 2023-03-25 08:56:03 PDT
fixed by https://bugs.webkit.org/show_bug.cgi?id=220082
Note You need to log in before you can comment on or make changes to this bug.