Bug 137727

Summary:

Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Layout and Rendering

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, darin, kling, mihnea

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

137424

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2014-10-14 18:56:24 PDT

Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine.

Comment 1 Chris Dumez 2014-10-14 19:00:21 PDT

Created attachment 239838 [details]
Patch

Comment 2 Darin Adler 2014-10-15 09:18:23 PDT

Comment on attachment 239838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239838&action=review

> Source/WebCore/page/EventHandler.cpp:3696
> +        if (auto* renderer = element->renderer()) {
> +            if (is<RenderTextControlSingleLine>(renderer))

Should either use *renderer here, or eliminate the if that checks renderer for null.

Comment 3 Chris Dumez 2014-10-15 10:16:55 PDT

Created attachment 239875 [details]
Patch

Comment 4 WebKit Commit Bot 2014-10-15 10:36:43 PDT

Comment on attachment 239875 [details]
Patch

Clearing flags on attachment: 239875

Committed r174732: <http://trac.webkit.org/changeset/174732>

Comment 5 WebKit Commit Bot 2014-10-15 10:36:48 PDT

All reviewed patches have been landed.  Closing bug.