Bug 137710

Summary: [Win] Enable Encrypted Media Support
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 134418, 137409    
Bug Blocks:    
Attachments:
Description Flags
Patch jer.noble: review+

Description Brent Fulgham 2014-10-14 12:23:03 PDT 
This patch makes the following changes:
1. Activate the ENCRYPTED_MEDIA_V2 support on Windows.
2. Handle possible calls to PlatformCALayerWinInternal::displayCallback on background queue.

We do not support performing display operations off the main thread, but some callbacks are generated in background queues. We need to re-dispatch such calls on the main thread to avoid violating this fundamental rule for our layout design.
Comment 1 Radar WebKit Bug Importer 2014-10-14 12:23:23 PDT 
<rdar://problem/18652699>
Comment 2 Brent Fulgham 2014-10-14 12:30:44 PDT 
Created attachment 239817 [details]
Patch
Comment 3 Jer Noble 2014-10-14 12:38:02 PDT 
Comment on attachment 239817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239817&action=review

r=me, with nit:

> Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:72
> +struct displayOnMainThreadContext {

Nit: displayOnMainThreadContext -> DisplayOnMainThreadContext
Comment 4 Brent Fulgham 2014-10-14 12:51:39 PDT 
Comment on attachment 239817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239817&action=review

>> Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:72
>> +struct displayOnMainThreadContext {
> 
> Nit: displayOnMainThreadContext -> DisplayOnMainThreadContext

It shall be done!
Comment 5 Brent Fulgham 2014-10-14 13:11:29 PDT 
Committed r174698: <http://trac.webkit.org/changeset/174698>