Bug 137495

Summary:

[iOS] WebKit1 clients crash in DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse()

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Platform

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, japhet, psolanki, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

153710

Attachments:

Description	Flags
Patch	none

Description Pratik Solanki 2014-10-07 12:36:24 PDT

In r173782, I moved the disk cache handling code from the main thread (UI thread) to the web thread when we are using WebKit1 on iOS. The code tries to access the CFCachedURLResponseRef passed in the block on the web thread. This is problematic because the object may have been released before the block gets to run on the web thread. We need to manually retain/release the response.

Comment 1 Pratik Solanki 2014-10-07 12:37:04 PDT

<rdar://problem/18495034>

Comment 2 Pratik Solanki 2014-10-07 12:38:36 PDT

Created attachment 239427 [details]
Patch

Comment 3 Andreas Kling 2014-10-07 13:00:46 PDT

Comment on attachment 239427 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2014-10-07 13:37:56 PDT

Comment on attachment 239427 [details]
Patch

Clearing flags on attachment: 239427

Committed r174404: <http://trac.webkit.org/changeset/174404>

Comment 5 WebKit Commit Bot 2014-10-07 13:38:01 PDT

All reviewed patches have been landed.  Closing bug.