Summary: | [Win] Extend AVFoundationCF Media Implementation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 137710 | ||||||||
Attachments: |
|
Description
Brent Fulgham
2014-10-03 15:06:25 PDT
Created attachment 239241 [details]
Patch
Created attachment 239242 [details]
Patch
Comment on attachment 239242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239242&action=review > Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:929 > + if (!keySystem.isEmpty()) { Nit: this could become an early return. > Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:2033 > + if (requestsIterator == m_keyURIToRequestMap.end()) { Nit: this could also become an early return. Committed r174346: <http://trac.webkit.org/changeset/174346> Build fix for machines without ENCYPTED_MEDIA_V2 enabled checked in under r174350: <http://trac.webkit.org/changeset/174350> |