Bug 137409

Summary: [Win] Extend AVFoundationCF Media Implementation
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 137710    
Attachments:
Description Flags
Patch
none
Patch none

Description Brent Fulgham 2014-10-03 15:06:25 PDT 
Correct  few errors in the existing AVFoundationCF implementation, and add initial support for encrypted streams.

This code is not being built as part of the standard build yet, and is not yet being tested. These changes are only accessible if you manually modify the ENCRYPTED_MEDIA_V2 is enabled.
Comment 1 Brent Fulgham 2014-10-03 15:17:59 PDT 
Created attachment 239241 [details]
Patch
Comment 2 Brent Fulgham 2014-10-03 15:22:12 PDT 
Created attachment 239242 [details]
Patch
Comment 3 Eric Carlson 2014-10-04 05:34:26 PDT 
Comment on attachment 239242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239242&action=review

> Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:929
> +    if (!keySystem.isEmpty()) {

Nit: this could become an early return.

> Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:2033
> +    if (requestsIterator == m_keyURIToRequestMap.end()) {

Nit: this could also become an early return.
Comment 4 Brent Fulgham 2014-10-06 10:49:28 PDT 
Committed r174346: <http://trac.webkit.org/changeset/174346>
Comment 5 Brent Fulgham 2014-10-06 11:02:20 PDT 
Build fix for machines without ENCYPTED_MEDIA_V2 enabled checked in under r174350:
<http://trac.webkit.org/changeset/174350>