Summary: | Add a ChromeClient API that gets called whenever the Page's audio playing state has changed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||
Component: | Media | Assignee: | Ada Chan <adachan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, jer.noble | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 137050 | ||||||
Attachments: |
|
Description
Ada Chan
2014-09-29 11:27:56 PDT
Created attachment 239344 [details]
Patch
Comment on attachment 239344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239344&action=review r=me, with nit. > Source/WebCore/page/ChromeClient.h:434 > + virtual void isPlayingAudioDidChange(bool /*newIsPlayingAudio*/) { } Nit: You don't need to include the (commented out) parameter name here. It's obvious from the function name. (In reply to comment #2) > (From update of attachment 239344 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239344&action=review > > r=me, with nit. > > > Source/WebCore/page/ChromeClient.h:434 > > + virtual void isPlayingAudioDidChange(bool /*newIsPlayingAudio*/) { } > > Nit: You don't need to include the (commented out) parameter name here. It's obvious from the function name. I'll remove it. Thanks for the review! Committed: https://trac.webkit.org/changeset/174365 |