Bug 137103

Summary: Use is<HTML*Element>() instead of isHTML*Element() - Part 2
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 137015    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-09-24 20:31:41 PDT 
Use is<HTML*Element>() instead of isHTML*Element() and drop support for the generated isHTML*Element() macros.
Comment 1 Chris Dumez 2014-09-24 21:46:51 PDT 
Created attachment 238640 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-09-25 04:00:15 PDT 
Comment on attachment 238640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238640&action=review

> Source/WebCore/css/CSSStyleSheet.cpp:39
> +#include "SVGStyleElement.H"

SVGStyleElement.H -> SVGStyleElement.h
Comment 3 Chris Dumez 2014-09-25 10:29:30 PDT 
Created attachment 238662 [details]
Patch
Comment 4 Chris Dumez 2014-09-25 10:30:57 PDT 
Created attachment 238663 [details]
Patch
Comment 5 Chris Dumez 2014-09-25 13:50:22 PDT 
(In reply to comment #2)
> (From update of attachment 238640 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238640&action=review
> 
> > Source/WebCore/css/CSSStyleSheet.cpp:39
> > +#include "SVGStyleElement.H"
> 
> SVGStyleElement.H -> SVGStyleElement.h

Thanks, fixed.
Comment 6 Benjamin Poulain 2014-09-25 15:02:41 PDT 
Comment on attachment 238663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238663&action=review

> Source/WebCore/css/CSSDefaultStyleSheets.cpp:65
>  static inline bool elementCanUseSimpleDefaultStyle(Element* e)

The argument should be a reference.

"e" should be element.

> Source/WebCore/html/HTMLNameCollection.cpp:54
> +    return is<HTMLImageElement>(element) || is<HTMLFormElement>(element) || element.hasTagName(appletTag)

I guess element.hasTagName(appletTag) is one of the special case?
Comment 7 Chris Dumez 2014-09-25 15:04:34 PDT 
Comment on attachment 238663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238663&action=review

>> Source/WebCore/html/HTMLNameCollection.cpp:54
>> +    return is<HTMLImageElement>(element) || is<HTMLFormElement>(element) || element.hasTagName(appletTag)
> 
> I guess element.hasTagName(appletTag) is one of the special case?

No, I missed it :)
Comment 8 Chris Dumez 2014-09-25 15:17:59 PDT 
Created attachment 238677 [details]
Patch
Comment 9 Chris Dumez 2014-09-25 15:36:54 PDT 
Created attachment 238678 [details]
Patch
Comment 10 WebKit Commit Bot 2014-09-25 16:37:18 PDT 
Comment on attachment 238678 [details]
Patch

Clearing flags on attachment: 238678

Committed r173980: <http://trac.webkit.org/changeset/173980>
Comment 11 WebKit Commit Bot 2014-09-25 16:37:24 PDT 
All reviewed patches have been landed.  Closing bug.