Summary: | Cannot start a drag inside a shadow tree when an inclusive-ancestor of its shadow host is a draggable element | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achim.weimert, eoconnor, ews-watchlist, rniwa, ryanhaddad, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 148695 | ||||||||||||
Attachments: |
|
Description
Jer Noble
2014-09-15 14:23:03 PDT
(In reply to Jer Noble from comment #0) > Investigate whether drags from within the shadow DOM should initiate drag > events targetting the hosting element. It should! *** Bug 187940 has been marked as a duplicate of this bug. *** *** Bug 186994 has been marked as a duplicate of this bug. *** Created attachment 350336 [details]
Fixes the bug
Comment on attachment 350336 [details] Fixes the bug Attachment 350336 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9293579 New failing tests: fast/shadow-dom/dragging-element-with-shadow-tree.html fast/shadow-dom/dragging-element-inside-shadow-tree.html Created attachment 350343 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
WTF!? Why is iOS WK2 running these tests? (In reply to Ryosuke Niwa from comment #8) > WTF!? Why is iOS WK2 running these tests? This pre-existing TestExpectations entry is probably to blame: LayoutTests/platform/ios/TestExpectations:781:webkit.org/b/148695 fast/shadow-dom [ Pass ] Created attachment 350452 [details]
Skip the tests on iOS for real
Created attachment 350496 [details]
Fixed GTK+ build
Thanks for the review! Committed r236384: <https://trac.webkit.org/changeset/236384> Mass move bugs into the DOM component. |