Bug 136399

Summary:

DOMTimer::m_nestingLevel is prone to overflow

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebCore Misc.

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	ap: review+

Description Gavin Barraclough 2014-08-29 17:21:39 PDT

Since this would happen after the 2 billionth timer fire this is unlikely, and consequences aren't severe (breaks throttling).

Comment 1 Gavin Barraclough 2014-08-29 17:41:18 PDT

Created attachment 237395 [details]
Fix

Comment 2 Alexey Proskuryakov 2014-08-29 18:02:28 PDT

Comment on attachment 237395 [details]
Fix

Not related to this patch, but looks like we have a thread safety issue with nestingLevel and workers.

Comment 3 Gavin Barraclough 2014-08-29 18:13:16 PDT

Transmitting file data ..
Committed revision 173132.

Comment 4 Gavin Barraclough 2014-08-29 21:35:24 PDT

(In reply to comment #2)
> (From update of attachment 237395 [details])
> Not related to this patch, but looks like we have a thread safety issue with nestingLevel and workers.

Good point! Fixed in: https://bugs.webkit.org/show_bug.cgi?id=136401