Bug 136399

Summary: DOMTimer::m_nestingLevel is prone to overflow
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: WebCore Misc.Assignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix ap: review+

Gavin Barraclough
Reported 2014-08-29 17:21:39 PDT
Since this would happen after the 2 billionth timer fire this is unlikely, and consequences aren't severe (breaks throttling).
Attachments
Fix (4.72 KB, patch)
2014-08-29 17:41 PDT, Gavin Barraclough 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2014-08-29 17:41:18 PDT
Created attachment 237395 [details] Fix
Alexey Proskuryakov
Comment 2 2014-08-29 18:02:28 PDT
Comment on attachment 237395 [details] Fix Not related to this patch, but looks like we have a thread safety issue with nestingLevel and workers.
Gavin Barraclough
Comment 3 2014-08-29 18:13:16 PDT
Transmitting file data .. Committed revision 173132.
Gavin Barraclough
Comment 4 2014-08-29 21:35:24 PDT
(In reply to comment #2) > (From update of attachment 237395 [details]) > Not related to this patch, but looks like we have a thread safety issue with nestingLevel and workers. Good point! Fixed in: https://bugs.webkit.org/show_bug.cgi?id=136401
Note You need to log in before you can comment on or make changes to this bug.