Bug 136355

Summary: [EFL] Remove E_Dbus dependency
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi, tmpsantos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 139120    
Attachments:
Description Flags
WorkInProgress
none
Patch
none
Patch
none
rebased none

Ryuan Choi
Reported 2014-08-28 16:29:44 PDT
Since EFL 1.8, E_Dbus is deprecated. Now we depends E_Dbus because of Battery Status and we can use eldbus instead of E_Dbus for it.
Attachments
WorkInProgress (15.97 KB, patch)
2014-08-28 18:28 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (20.92 KB, patch)
2014-11-18 14:53 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (24.65 KB, patch)
2014-11-18 15:04 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
rebased (24.56 KB, patch)
2014-11-27 22:10 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-08-28 18:28:53 PDT
Created attachment 237335 [details] WorkInProgress
Ryuan Choi
Comment 2 2014-11-18 14:53:44 PST
Created attachment 241815 [details] Patch
Ryuan Choi
Comment 3 2014-11-18 15:04:44 PST
Created attachment 241818 [details] Patch
Ryuan Choi
Comment 4 2014-11-26 04:45:40 PST
gyuyoung, could you review this?
Gyuyoung Kim
Comment 5 2014-11-26 04:56:57 PST
Comment on attachment 241818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241818&action=review Patch looks fine to me. However I feel I need to take a look this patch further. Let me do it tomorrow. > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:158 > + if (type != 2) // BATTERY I don't understand What does "// BATTERY" comment means. > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:181 > + Eldbus_Object* object = eldbus_object_get(static_cast<BatteryProviderEfl*>(data)->connection(), BUS, path); Don't we need to check if object is null ?
Ryuan Choi
Comment 6 2014-11-27 22:10:17 PST
Created attachment 242260 [details] rebased
Ryuan Choi
Comment 7 2014-11-27 22:11:04 PST
(In reply to comment #5) > Comment on attachment 241818 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241818&action=review > > Patch looks fine to me. However I feel I need to take a look this patch > further. Let me do it tomorrow. > > > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:158 > > + if (type != 2) // BATTERY > > I don't understand What does "// BATTERY" comment means. > > > Source/WebCore/platform/efl/BatteryProviderEfl.cpp:181 > > + Eldbus_Object* object = eldbus_object_get(static_cast<BatteryProviderEfl*>(data)->connection(), BUS, path); > > Don't we need to check if object is null ? Sure, rebased with what you addressed.
Gyuyoung Kim
Comment 8 2014-11-27 22:12:47 PST
Comment on attachment 242260 [details] rebased LGTM.
WebKit Commit Bot
Comment 9 2014-11-27 23:03:54 PST
Comment on attachment 242260 [details] rebased Clearing flags on attachment: 242260 Committed r176555: <http://trac.webkit.org/changeset/176555>
WebKit Commit Bot
Comment 10 2014-11-27 23:04:00 PST
All reviewed patches have been landed. Closing bug.
Ryuan Choi
Comment 11 2015-05-19 21:53:03 PDT
*** Bug 101866 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.