Bug 136050

Summary: [JSC] Build error on ARM64 with gcc: signed/unsigned comparison error in JSC::GPRInfo::debugName
Product: WebKit Reporter: Akos Kiss <akiss>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, fpizlo, msaboff, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Proposed patch. none

Description Akos Kiss 2014-08-18 14:35:44 PDT
When compilig debug version of JSC for arm64 with gcc, the following error is raised:

/home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h: In static member function ‘static const char* JSC::GPRInfo::debugName(JSC::GPRReg)’:
/home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h:35:41: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
 #define InvalidGPRReg ((::JSC::GPRReg)-1)
                                         ^
/home/akiss/devel/WebKit/Source/WTF/wtf/Assertions.h:237:8: note: in definition of macro ‘ASSERT’
     (!(assertion) ? \
        ^
/home/akiss/devel/WebKit/Source/JavaScriptCore/jit/GPRInfo.h:615:46: note: in expansion of macro ‘InvalidGPRReg’
         ASSERT(static_cast<unsigned>(reg) != InvalidGPRReg);
                                              ^
Comment 1 Akos Kiss 2014-08-18 14:44:32 PDT
Created attachment 236788 [details]
Proposed patch.

This change makes the ASSERT in the ARM64 version of GPRInfo::debugName the same as in the other implementations.
Comment 2 WebKit Commit Bot 2014-08-18 16:20:17 PDT
Comment on attachment 236788 [details]
Proposed patch.

Clearing flags on attachment: 236788

Committed r172734: <http://trac.webkit.org/changeset/172734>
Comment 3 WebKit Commit Bot 2014-08-18 16:20:19 PDT
All reviewed patches have been landed.  Closing bug.