Summary: | Don't recurse into non-rendered subtrees when computing style | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, glenn, jer.noble, philipj, rniwa, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 135864 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Antti Koivisto
2014-08-12 11:00:24 PDT
Created attachment 236455 [details]
patch
Comment on attachment 236455 [details] patch Attachment 236455 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5504208803463168 New failing tests: fast/ruby/ruby-base-merge-block-children-crash-2.html http/tests/security/video-poster-cross-origin-crash.html Created attachment 236458 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 236463 [details]
patch 2
Comment on attachment 236463 [details] patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=236463&action=review r=me > Source/WebCore/ChangeLog:11 > + Do a simple reset of the style dirty bits and any computed style in non-renderer subtrees. Typo, non-renderer -> non-rendered. > Source/WebCore/style/StyleResolveTree.cpp:561 > + for (auto& child : childrenOfType<Element>(current)) { I suspect this could be more efficient with elementDescendants. Re-opened since this is blocked by bug 135864 Re-landed in https://trac.webkit.org/r172517 ...and the test rebase https://trac.webkit.org/r172518 |