Bug 135844 – Don't recurse into non-rendered subtrees when computing style

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antti Koivisto]

We can avoid some work.

[Antti Koivisto]

Created attachment 236455 [details]
patch

[Build Bot]

Comment on attachment 236455 [details]
patch

Attachment 236455 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5504208803463168

New failing tests:
fast/ruby/ruby-base-merge-block-children-crash-2.html
http/tests/security/video-poster-cross-origin-crash.html

[Build Bot]

Created attachment 236458 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Antti Koivisto]

Created attachment 236463 [details]
patch 2

[Andreas Kling]

Comment on attachment 236463 [details]
patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=236463&action=review

r=me

> Source/WebCore/ChangeLog:11
> +        Do a simple reset of the style dirty bits and any computed style in non-renderer subtrees.

Typo, non-renderer -> non-rendered.

> Source/WebCore/style/StyleResolveTree.cpp:561
> +    for (auto& child : childrenOfType<Element>(current)) {

I suspect this could be more efficient with elementDescendants.

[Antti Koivisto]

https://trac.webkit.org/r172494

[WebKit Commit Bot]

Re-opened since this is blocked by bug 135864

[Antti Koivisto]

Re-landed in https://trac.webkit.org/r172517

[Antti Koivisto]

...and the test rebase https://trac.webkit.org/r172518