Bug 135019

Summary: [ftlopt] DFG Flush(SetLocal) store elimination is overzealous for captured variables in the presence of nodes that have no effects but may throw (merge trunk r171190)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 134988    
Bug Blocks:    
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2014-07-17 12:28:13 PDT
This is about merging https://bugs.webkit.org/show_bug.cgi?id=134988. The merge requires some finesse so I'd rather get another review.
Attachments
the patch (6.24 KB, patch)
2014-07-17 12:31 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-07-17 12:31:15 PDT
Created attachment 235084 [details] the patch
Filip Pizlo
Comment 2 2014-07-17 22:56:20 PDT
Landed in http://trac.webkit.org/changeset/171214
Note You need to log in before you can comment on or make changes to this bug.