| Summary: | DFG Flush(SetLocal) store elimination is overzealous for captured variables in the presence of nodes that have no effects but may throw | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | barraclough, buildbot, ggaren, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 134945, 135019 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2014-07-16 12:09:31 PDT
Created attachment 235014 [details]
the patch
Comment on attachment 235014 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=235014&action=review r=me > Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:970 > // Be safe in release mode. This comment doesn't make sense any more. Comment on attachment 235014 [details] the patch Attachment 235014 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4745035249614848 New failing tests: media/media-fragments/TC0001.html Created attachment 235022 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 235045 [details]
the patch
Landed in http://trac.webkit.org/changeset/171190 |