Bug 134793
| Summary: | media/W3C/video/readyState/readyState_during_canplay.html often flakey | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Media | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, eric.carlson, jer.noble, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
Often in EWS:
New failing tests:
media/W3C/video/readyState/readyState_during_canplay.html
e.g. in bug 134789.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
See also bug 122475. I think that this is a misplaced failure due to another test timing out.
Ahmad Saleem
We can delete this local copy of test in favor of WPT:
https://wpt.fyi/results/html/semantics/embedded-content/media-elements/readyState_during_canplay.html?label=experimental&label=master&aligned=
and update this expectation:
https://searchfox.org/wubkat/source/LayoutTests/platform/mac-wk2/TestExpectations#1014
[ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplay.html [ Pass Failure ]
____
Can do PR with following:
1) Delete local copy of test
2) Import single new copy of above test from WPT
3) Remove above 'Test Expectation
4) Run through EWS to see if it works across all platforms
5) If all good then enable it and if not, then raise platform specific bugs and track in newer bug
___
Any input / suggestions?
Eric Carlson
(In reply to Ahmad Saleem from comment #2)
> We can delete this local copy of test in favor of WPT:
>
> https://wpt.fyi/results/html/semantics/embedded-content/media-elements/
> readyState_during_canplay.html?label=experimental&label=master&aligned=
>
> and update this expectation:
>
> https://searchfox.org/wubkat/source/LayoutTests/platform/mac-wk2/
> TestExpectations#1014
>
>
> [ Release ]
> imported/w3c/web-platform-tests/html/semantics/embedded-content/media-
> elements/readyState_during_canplay.html [ Pass Failure ]
>
> ____
>
> Can do PR with following:
>
> 1) Delete local copy of test
> 2) Import single new copy of above test from WPT
> 3) Remove above 'Test Expectation
> 4) Run through EWS to see if it works across all platforms
> 5) If all good then enable it and if not, then raise platform specific bugs
> and track in newer bug
>
> ___
>
> Any input / suggestions?
Good plan, thank you!
Ahmad Saleem
Copy in our tree is latest from WPT, so just removing old test case and expectation: https://github.com/WebKit/WebKit/pull/19659
EWS
Committed 269894@main (ed96df022f4f): <https://commits.webkit.org/269894@main>
Reviewed commits have been landed. Closing PR #19659 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/117633522>