| Summary: | [ftlopt] Allocate a new GetterSetter if we change the value of any of its entries other than when they were previously null, so that if we constant-infer an accessor slot then we immediately get the function constant for free | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | barraclough, buildbot, bunhere, cdumez, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam, sergio | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 129588, 134962 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2014-07-01 15:42:47 PDT
Created attachment 234239 [details]
the patch
Comment on attachment 234239 [details] the patch Attachment 234239 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6001767712030720 New failing tests: js/pic/cached-prototype-setter.html js/dom/Object-defineProperty.html Created attachment 234240 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 234239 [details] the patch Attachment 234239 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5050185495347200 New failing tests: js/pic/cached-prototype-setter.html js/dom/Object-defineProperty.html Created attachment 234252 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 234239 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=234239&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + setSetter/setGetter were already allocating a branch new GetterSetter. But once we start a brand new Landed in http://trac.webkit.org/changeset/170729 |