Bug 134518 - [ftlopt] Allocate a new GetterSetter if we change the value of any of its entries other than when they were previously null, so that if we constant-infer an accessor slot then we immediately get the function constant for free
Summary: [ftlopt] Allocate a new GetterSetter if we change the value of any of its ent...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 129588 134962
  Show dependency tree / graph
 
Reported: 2014-07-01 15:42 PDT by Filip Pizlo
Modified: 2014-07-15 21:09 PDT (History)
14 users (show)

See Also:

Attachments
the patch (6.46 KB, patch)
2014-07-01 21:22 PDT, Filip Pizlo 		mhahnenberg: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (526.82 KB, application/zip)
2014-07-01 22:45 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (547.89 KB, application/zip)
2014-07-02 04:53 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-07-01 15:42:47 PDT 
...
Comment 1 Filip Pizlo 2014-07-01 21:22:53 PDT 
Created attachment 234239 [details]
the patch
Comment 2 Build Bot 2014-07-01 22:45:47 PDT 
Comment on attachment 234239 [details]
the patch

Attachment 234239 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6001767712030720

New failing tests:
js/pic/cached-prototype-setter.html
js/dom/Object-defineProperty.html
Comment 3 Build Bot 2014-07-01 22:45:52 PDT 
Created attachment 234240 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-07-02 04:53:03 PDT 
Comment on attachment 234239 [details]
the patch

Attachment 234239 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5050185495347200

New failing tests:
js/pic/cached-prototype-setter.html
js/dom/Object-defineProperty.html
Comment 5 Build Bot 2014-07-02 04:53:07 PDT 
Created attachment 234252 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Mark Hahnenberg 2014-07-02 13:58:37 PDT 
Comment on attachment 234239 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234239&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        setSetter/setGetter were already allocating a branch new GetterSetter. But once we start

a brand new
Comment 7 Filip Pizlo 2014-07-02 15:35:19 PDT 
Landed in http://trac.webkit.org/changeset/170729