RESOLVED FIXED 134518
[ftlopt] Allocate a new GetterSetter if we change the value of any of its entries other than when they were previously null, so that if we constant-infer an accessor slot then we immediately get the function constant for free 
https://bugs.webkit.org/show_bug.cgi?id=134518
Summary [ftlopt] Allocate a new GetterSetter if we change the value of any of its ent...
Filip Pizlo
Reported 2014-07-01 15:42:47 PDT
...
Attachments
the patch (6.46 KB, patch)
2014-07-01 21:22 PDT, Filip Pizlo 		mhahnenberg: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (526.82 KB, application/zip)
2014-07-01 22:45 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (547.89 KB, application/zip)
2014-07-02 04:53 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-07-01 21:22:53 PDT
Created attachment 234239 [details] the patch
Build Bot
Comment 2 2014-07-01 22:45:47 PDT
Comment on attachment 234239 [details] the patch Attachment 234239 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6001767712030720 New failing tests: js/pic/cached-prototype-setter.html js/dom/Object-defineProperty.html
Build Bot
Comment 3 2014-07-01 22:45:52 PDT
Created attachment 234240 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 4 2014-07-02 04:53:03 PDT
Comment on attachment 234239 [details] the patch Attachment 234239 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5050185495347200 New failing tests: js/pic/cached-prototype-setter.html js/dom/Object-defineProperty.html
Build Bot
Comment 5 2014-07-02 04:53:07 PDT
Created attachment 234252 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Mark Hahnenberg
Comment 6 2014-07-02 13:58:37 PDT
Comment on attachment 234239 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=234239&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + setSetter/setGetter were already allocating a branch new GetterSetter. But once we start a brand new
Filip Pizlo
Comment 7 2014-07-02 15:35:19 PDT
Landed in http://trac.webkit.org/changeset/170729
Note You need to log in before you can comment on or make changes to this bug.