Bug 134261

Summary: use references instead of pointers in RenderTheme
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Layout and RenderingAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, peavo, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 134106    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch zalan: review+, commit-queue: commit-queue-

Alex Christensen
Reported 2014-06-24 12:05:41 PDT
There is inconsistent use of references, and I don't see any reason why there shouldn't be references.
Attachments
Patch (89.02 KB, patch)
2014-06-24 12:06 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (150.92 KB, patch)
2014-06-24 15:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (173.29 KB, patch)
2014-06-24 16:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (204.89 KB, patch)
2014-06-24 16:46 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (206.11 KB, patch)
2014-06-24 16:59 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (210.91 KB, patch)
2014-06-24 17:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (213.82 KB, patch)
2014-06-24 22:11 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (215.64 KB, patch)
2014-06-25 09:48 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (215.73 KB, patch)
2014-06-25 10:00 PDT, Alex Christensen 		zalan: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-06-24 12:06:54 PDT
Created attachment 233727 [details] Patch
zalan
Comment 2 2014-06-24 12:48:45 PDT
wait for the elf/gtk bots. they both have dependencies on the theme signature.
Alex Christensen
Comment 3 2014-06-24 15:38:37 PDT
Created attachment 233754 [details] Patch
Alex Christensen
Comment 4 2014-06-24 16:14:13 PDT
Created attachment 233758 [details] Patch
Alex Christensen
Comment 5 2014-06-24 16:46:41 PDT
Created attachment 233764 [details] Patch
Alex Christensen
Comment 6 2014-06-24 16:59:40 PDT
Created attachment 233766 [details] Patch
Alex Christensen
Comment 7 2014-06-24 17:36:39 PDT
Created attachment 233769 [details] Patch
zalan
Comment 8 2014-06-24 19:01:55 PDT
one more to go :)
Alex Christensen
Comment 9 2014-06-24 22:11:02 PDT
Created attachment 233787 [details] Patch
Alex Christensen
Comment 10 2014-06-25 09:48:01 PDT
Created attachment 233820 [details] Patch
Alex Christensen
Comment 11 2014-06-25 10:00:26 PDT
Created attachment 233822 [details] Patch
Alex Christensen
Comment 12 2014-06-25 11:28:34 PDT
*** Bug 134106 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 13 2014-06-25 14:00:08 PDT
Comment on attachment 233822 [details] Patch Rejecting attachment 233822 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 233822, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5171847423328256
Alex Christensen
Comment 14 2014-06-25 14:05:31 PDT
http://trac.webkit.org/changeset/170435
Note You need to log in before you can comment on or make changes to this bug.