| Summary: | use references instead of pointers in RenderTheme | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Alex Christensen <achristensen> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | andersca, commit-queue, peavo, zalan | ||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||
| OS: | All | ||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||
| Bug Blocks: | 134106 | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Alex Christensen
2014-06-24 12:05:41 PDT
Created attachment 233727 [details]
Patch
wait for the elf/gtk bots. they both have dependencies on the theme signature. Created attachment 233754 [details]
Patch
Created attachment 233758 [details]
Patch
Created attachment 233764 [details]
Patch
Created attachment 233766 [details]
Patch
Created attachment 233769 [details]
Patch
one more to go :) Created attachment 233787 [details]
Patch
Created attachment 233820 [details]
Patch
Created attachment 233822 [details]
Patch
*** Bug 134106 has been marked as a duplicate of this bug. *** Comment on attachment 233822 [details] Patch Rejecting attachment 233822 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 233822, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5171847423328256 |