| Summary: | REGRESSION(r170235): Remove incorrect ifdef guard | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Éva Balázsfalvi <evab.u-szeged> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, enrica, gyuyoung.kim, ossy, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 133844 | ||||||
| Attachments: |
|
||||||
Created attachment 233692 [details]
Patch
(In reply to comment #1) > Created an attachment (id=233692) [details] > Patch https://bugs.webkit.org/show_bug.cgi?id=133844#c4 > -#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) > +#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) I agree, this guard is really unnecessary, "true || FOO" is always true. Comment on attachment 233692 [details]
Patch
LGTM, r=me. Thanks for the quick fix.
Comment on attachment 233692 [details] Patch Clearing flags on attachment: 233692 Committed r170358: <http://trac.webkit.org/changeset/170358> All reviewed patches have been landed. Closing bug. This breaks the build for all the platforms that do not enable HIDDEN_PAGE_DOM_TIMER_THROTTLING. You removed the #ifdef but you left it around the kit function on line 521. (In reply to comment #6) > This breaks the build for all the platforms that do not enable HIDDEN_PAGE_DOM_TIMER_THROTTLING. > You removed the #ifdef but you left it around the kit function on line 521. In this case the original guarding was incorrect. This call was guarded with "#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)". But now there isn't PAGE_VISIBILITY_API guard, so we need this kit call unconditionally. Should we remove guards around kit function core? Thanks for the fix landed in https://trac.webkit.org/changeset/170372 . |
Removr unnecessary #if guard which remained in the code while removing PAGE_VISIBILITY_API compile guard. > Source/WebKit/mac/WebView/WebView.mm:4328 > #if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) > if (_private->page) > return kit(_private->page->visibilityState()); > #endif