Bug 134108

Summary:

Gamepad API - "Deprecate" the existing implementation

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bunhere, cdumez, cmarcelo, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rakuco, sergio, syoichi

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

134157

Bug Blocks:

134076

Attachments:

Description	Flags
Patch v1	timothy: review+, beidson: commit-queue+
Patch for landing	commit-queue: commit-queue-
Patch for landing with Timothy's full name (thanks, automation!)	beidson: commit-queue-
Patch for landing v172	none
New approach - v1	none

Brady Eidson

Reported 2014-06-20 10:08:56 PDT

Gamepad API - "Deprecate" the existing implementation To cause less pain while implementing the new Gamepad API (https://bugs.webkit.org/show_bug.cgi?id=134076) the old version should be left in the tree deprecated. This will include renaming "GAMEPAD" to "GAMEPAD_DEPRECATED", as well as appending the "Deprecated" prefix to the files in the tree that will conflict with the new implementation.

Attachments
Patch v1 (67.73 KB, patch) 2014-06-20 11:43 PDT, Brady Eidson	timothy: review+ beidson: commit-queue+	Details Formatted Diff Diff
Patch for landing (67.71 KB, patch) 2014-06-20 15:06 PDT, Brady Eidson	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing with Timothy's full name (thanks, automation!) (67.74 KB, patch) 2014-06-20 20:04 PDT, Brady Eidson	beidson: commit-queue-	Details Formatted Diff Diff
Patch for landing v172 (67.58 KB, patch) 2014-06-21 07:56 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
New approach - v1 (79.33 KB, patch) 2014-06-21 10:04 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2014-06-20 11:43:53 PDT

Created attachment 233438 [details] Patch v1

Brady Eidson

Comment 2 2014-06-20 11:47:11 PDT

Because of the EFL build-breakage list, I'll wait for EWS on this one before commit-queueing it

Brady Eidson

Comment 3 2014-06-20 14:11:33 PDT

Build was broken without the patch, so I'll land it.

Brady Eidson

Comment 4 2014-06-20 15:06:49 PDT

Created attachment 233463 [details] Patch for landing Commit queue was busted because of turbulence in the tree - trying again.

WebKit Commit Bot

Comment 5 2014-06-20 19:17:50 PDT

Comment on attachment 233463 [details] Patch for landing Rejecting attachment 233463 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 233463, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Tim Hatcher found in /Volumes/Data/EWS/WebKit/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/6346875045150720

Brady Eidson

Comment 6 2014-06-20 20:04:02 PDT

Created attachment 233501 [details] Patch for landing with Timothy's full name (thanks, automation!)

Brady Eidson

Comment 7 2014-06-21 07:49:56 PDT

Okay one more CQ try now that we suspect it should be unwedged.

Brady Eidson

Comment 8 2014-06-21 07:56:04 PDT

Created attachment 233533 [details] Patch for landing v172

WebKit Commit Bot

Comment 9 2014-06-21 08:44:15 PDT

Comment on attachment 233533 [details] Patch for landing v172 Clearing flags on attachment: 233533 Committed r170244: <http://trac.webkit.org/changeset/170244>

WebKit Commit Bot

Comment 10 2014-06-21 08:44:19 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 11 2014-06-21 09:21:02 PDT

Re-opened since this is blocked by bug 134157

Brady Eidson

Comment 12 2014-06-21 10:04:55 PDT

Created attachment 233537 [details] New approach - v1 Instead of suffix'ing the old files with "Deprecated", just move them as-is into a "deprecated" subdirectory This is for an EWS run

WebKit Commit Bot

Comment 13 2014-06-21 10:07:09 PDT

Attachment 233537 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/gamepad/deprecated/GamepadList.h:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 14 2014-06-21 10:27:21 PDT

EFL down, GTK to go.

Brady Eidson

Comment 15 2014-06-21 11:36:14 PDT

The GTK build breakage is not due to this patch. Landing it!

WebKit Commit Bot

Comment 16 2014-06-21 12:07:34 PDT

Comment on attachment 233537 [details] New approach - v1 Clearing flags on attachment: 233537 Committed r170249: <http://trac.webkit.org/changeset/170249>

WebKit Commit Bot

Comment 17 2014-06-21 12:07:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.