Bug 134106

Summary: [Win] Menu list theme is not drawn.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: achristensen, alex.christensen, bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Bug Depends on: 134261    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description peavo 2014-06-20 08:35:43 PDT 
Dropdown menus are not rendered on Windows.
A virtual drawing method has changed signature, and the override on Windows needs updating.
Comment 1 peavo 2014-06-20 08:42:43 PDT 
Created attachment 233429 [details]
Patch
Comment 2 Alex Christensen 2014-06-20 08:59:57 PDT 
Comment on attachment 233429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233429&action=review

> Source/WebCore/rendering/RenderThemeWin.cpp:803
> +    adjustMenuListButtonStyle(*styleResolver, *style, *e);

I think RenderTheme::adjustStyle should be changed to pass references instead of pointers so we don't have to dereference unchecked pointers into references here.
Comment 3 peavo 2014-06-20 11:25:29 PDT 
(In reply to comment #2)
> (From update of attachment 233429 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233429&action=review
> 

Thanks for looking into this :)

> > Source/WebCore/rendering/RenderThemeWin.cpp:803
> > +    adjustMenuListButtonStyle(*styleResolver, *style, *e);
> 
> I think RenderTheme::adjustStyle should be changed to pass references instead of pointers so we don't have to dereference unchecked pointers into references here.

I agree, could we perhaps address this in a separate patch, since it's a bigger change, involving all platforms?
Comment 4 Alex Christensen 2014-06-25 11:28:34 PDT 
I've incorporated this into https://bugs.webkit.org/show_bug.cgi?id=134261 and given you credit.  It will be fixed once that clears all ews bots.

*** This bug has been marked as a duplicate of bug 134261 ***
Comment 5 peavo 2014-06-25 12:34:05 PDT 
(In reply to comment #4)
> I've incorporated this into https://bugs.webkit.org/show_bug.cgi?id=134261 and given you credit.  It will be fixed once that clears all ews bots.
> 

Sounds good, thanks :)

> *** This bug has been marked as a duplicate of bug 134261 ***