Bug 133985

Summary: [ftlopt] Get rid of NodeDoesNotExit and also get rid of StoreEliminationPhase
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 133918    
Attachments:
Description Flags
the patch msaboff: review+

Filip Pizlo
Reported 2014-06-17 10:33:10 PDT
Patch forthcoming.
Attachments
the patch (71.97 KB, patch)
2014-06-17 10:38 PDT, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-06-17 10:33:28 PDT
*** Bug 130521 has been marked as a duplicate of this bug. ***
Filip Pizlo
Comment 2 2014-06-17 10:33:48 PDT
*** Bug 110383 has been marked as a duplicate of this bug. ***
Filip Pizlo
Comment 3 2014-06-17 10:38:47 PDT
Created attachment 233243 [details] the patch
Michael Saboff
Comment 4 2014-06-17 10:45:33 PDT
Comment on attachment 233243 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=233243&action=review r=me, I like the read. One typo. > Source/JavaScriptCore/ChangeLog:18 > + other optimizations that previously relied upomn NodeDoesNotExit. *upon*
Mark Hahnenberg
Comment 5 2014-06-17 10:51:21 PDT
Comment on attachment 233243 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=233243&action=review r=me too > Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h:91 > // Indicate the start of execution of the node. It resets any state in the node, s/node,$/node
Filip Pizlo
Comment 6 2014-06-17 10:53:21 PDT
Landed in http://trac.webkit.org/changeset/170060
Note You need to log in before you can comment on or make changes to this bug.