Bug 133985

Summary: [ftlopt] Get rid of NodeDoesNotExit and also get rid of StoreEliminationPhase
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 133918    
Attachments:
Description Flags
the patch msaboff: review+

Description Filip Pizlo 2014-06-17 10:33:10 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2014-06-17 10:33:28 PDT
*** Bug 130521 has been marked as a duplicate of this bug. ***
Comment 2 Filip Pizlo 2014-06-17 10:33:48 PDT
*** Bug 110383 has been marked as a duplicate of this bug. ***
Comment 3 Filip Pizlo 2014-06-17 10:38:47 PDT
Created attachment 233243 [details]
the patch
Comment 4 Michael Saboff 2014-06-17 10:45:33 PDT
Comment on attachment 233243 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233243&action=review

r=me,  I like the read.  One typo.

> Source/JavaScriptCore/ChangeLog:18
> +        other optimizations that previously relied upomn NodeDoesNotExit.

*upon*
Comment 5 Mark Hahnenberg 2014-06-17 10:51:21 PDT
Comment on attachment 233243 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233243&action=review

r=me too

> Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h:91
>      // Indicate the start of execution of the node. It resets any state in the node,

s/node,$/node
Comment 6 Filip Pizlo 2014-06-17 10:53:21 PDT
Landed in http://trac.webkit.org/changeset/170060