Bug 133947

Summary: [ftlopt] DFG constant folding shouldn't have the silly setFoundConstants() compilation time optimization
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED INVALID    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 133918    
Attachments:
Description Flags
the patch none

Description Filip Pizlo 2014-06-16 12:31:10 PDT 
It's probably not effective anymore and it constrains the amount of constant folding we can do.
Comment 1 Filip Pizlo 2014-06-16 12:34:31 PDT 
Created attachment 233171 [details]
the patch
Comment 2 Filip Pizlo 2014-06-16 16:04:34 PDT 
Comment on attachment 233171 [details]
the patch

Turns out this is a 1% SunSpider regression.  I guess I'll keep the optimization.