Bug 133947 - [ftlopt] DFG constant folding shouldn't have the silly setFoundConstants() compilation time optimization
Summary: [ftlopt] DFG constant folding shouldn't have the silly setFoundConstants() co...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 133918
  Show dependency tree / graph
 
Reported: 2014-06-16 12:31 PDT by Filip Pizlo
Modified: 2014-06-16 16:44 PDT (History)
7 users (show)

See Also:

Attachments
the patch (21.90 KB, patch)
2014-06-16 12:34 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-06-16 12:31:10 PDT 
It's probably not effective anymore and it constrains the amount of constant folding we can do.
Comment 1 Filip Pizlo 2014-06-16 12:34:31 PDT 
Created attachment 233171 [details]
the patch
Comment 2 Filip Pizlo 2014-06-16 16:04:34 PDT 
Comment on attachment 233171 [details]
the patch

Turns out this is a 1% SunSpider regression.  I guess I'll keep the optimization.