| Summary: | Regression r168397 - Form layout is incorrect on OS X Yosemite | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 133646 | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2014-06-07 15:55:27 PDT
Created attachment 232671 [details]
Patch
Comment on attachment 232671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232671&action=review > Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:71 > + return wkDrawFocusRingAtTime(context, DBL_MAX); Please use std::numeric_limits<double>::max() here. > Source/WebCore/platform/mac/ThemeMac.mm:379 > + wkDrawCellFocusRingWithFrameAtTime(cell, cellFrame, controlView, DBL_MAX); Same thing here. > Source/WebCore/rendering/RenderThemeMac.mm:928 > + if (wkDrawCellFocusRingWithFrameAtTime(popupButton, inflatedRect, view, DBL_MAX)) And here. Committed r169681: <http://trac.webkit.org/changeset/169681> This broke three tests on Mavericks and Mountain Lion at least (not sure about Yosemite): compositing/geometry/ancestor-overflow-change.html compositing/layer-creation/overlap-animation-container.html platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html Fixing in bug 133646. |