Bug 133438

Summary: DYEBench: Move test states into benchmarkClient and remove the closure
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, darin, kling, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 133437    
Bug Blocks:    
Attachments:
Description Flags
Cleanup
none
Reverted the erroneous change to the number of iterations benjamin: review+

Ryosuke Niwa
Reported 2014-06-01 13:52:01 PDT
The local variables in the closure used to keep states for benchmarkClient is making the code less comprehensible. Move them onto benchmarkClient itself.
Attachments
Cleanup (6.27 KB, patch)
2014-06-01 13:54 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Reverted the erroneous change to the number of iterations (6.25 KB, patch)
2014-06-01 13:57 PDT, Ryosuke Niwa 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2014-06-01 13:54:36 PDT
Created attachment 232355 [details] Cleanup
Ryosuke Niwa
Comment 2 2014-06-01 13:57:41 PDT
Created attachment 232356 [details] Reverted the erroneous change to the number of iterations
Ryosuke Niwa
Comment 3 2014-06-01 14:12:04 PDT
Thanks again!
Ryosuke Niwa
Comment 4 2014-06-01 14:12:27 PDT
Committed r169517: <http://trac.webkit.org/changeset/169517>
Note You need to log in before you can comment on or make changes to this bug.