Bug 133208

Summary: Share platform/mac/editing/spelling/move-cursor-around-misspelled-word.html with other platforms
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: HTML EditingAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126746    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

Grzegorz Czajkowski
Reported 2014-05-23 00:58:05 PDT
Move the test to common editing/spelling since it just verifies spelling markers and other platforms might be interested in running it as well. Due to bug 125688, the test starts using asynchronous spellchecking. Add additional test case which checks spelling marker after typing the text, before any caret change.
Attachments
Patch (11.50 KB, patch)
2014-05-23 01:01 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (546.01 KB, application/zip)
2014-05-23 07:11 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2014-05-23 01:01:21 PDT
Created attachment 231949 [details] Patch
Build Bot
Comment 2 2014-05-23 07:11:09 PDT
Comment on attachment 231949 [details] Patch Attachment 231949 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6627354168262656 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 3 2014-05-23 07:11:13 PDT
Created attachment 231963 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Grzegorz Czajkowski
Comment 4 2014-05-26 00:31:57 PDT
(In reply to comment #2) > (From update of attachment 231949 [details]) > Attachment 231949 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/6627354168262656 > > New failing tests: > media/W3C/video/networkState/networkState_during_loadstart.html The proposed patch doesn't cause this failure since it only changes move-cursor-around-misspelled-word.html
Grzegorz Czajkowski
Comment 5 2014-06-05 00:00:59 PDT
Ping reviewers. Thanks!
WebKit Commit Bot
Comment 6 2014-06-05 16:20:25 PDT
Comment on attachment 231949 [details] Patch Clearing flags on attachment: 231949 Committed r169629: <http://trac.webkit.org/changeset/169629>
WebKit Commit Bot
Comment 7 2014-06-05 16:20:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.