Bug 133208 - Share platform/mac/editing/spelling/move-cursor-around-misspelled-word.html with other platforms
Summary: Share platform/mac/editing/spelling/move-cursor-around-misspelled-word.html w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Grzegorz Czajkowski
URL:
Keywords:
Depends on:
Blocks: 126746
  Show dependency tree / graph
 
Reported: 2014-05-23 00:58 PDT by Grzegorz Czajkowski
Modified: 2014-06-05 16:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.50 KB, patch)
2014-05-23 01:01 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (546.01 KB, application/zip)
2014-05-23 07:11 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2014-05-23 00:58:05 PDT 
Move the test to common editing/spelling since it just verifies spelling markers and other platforms might be interested in running it as well.

Due to bug 125688, the test starts using asynchronous spellchecking.
Add additional test case which checks spelling marker after typing the text, before any caret change.
Comment 1 Grzegorz Czajkowski 2014-05-23 01:01:21 PDT 
Created attachment 231949 [details]
Patch
Comment 2 Build Bot 2014-05-23 07:11:09 PDT 
Comment on attachment 231949 [details]
Patch

Attachment 231949 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6627354168262656

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 3 Build Bot 2014-05-23 07:11:13 PDT 
Created attachment 231963 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Grzegorz Czajkowski 2014-05-26 00:31:57 PDT 
(In reply to comment #2)
> (From update of attachment 231949 [details])
> Attachment 231949 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/6627354168262656
> 
> New failing tests:
> media/W3C/video/networkState/networkState_during_loadstart.html

The proposed patch doesn't cause this failure since it only changes move-cursor-around-misspelled-word.html
Comment 5 Grzegorz Czajkowski 2014-06-05 00:00:59 PDT 
Ping reviewers. Thanks!
Comment 6 WebKit Commit Bot 2014-06-05 16:20:25 PDT 
Comment on attachment 231949 [details]
Patch

Clearing flags on attachment: 231949

Committed r169629: <http://trac.webkit.org/changeset/169629>
Comment 7 WebKit Commit Bot 2014-06-05 16:20:29 PDT 
All reviewed patches have been landed.  Closing bug.