Summary: | WebKit2/iOS: parented view should be considered hidden if app is backgrounded | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
Component: | WebKit2 | Assignee: | Gavin Barraclough <barraclough> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Gavin Barraclough
2014-05-19 17:35:59 PDT
Created attachment 231743 [details]
Fix
Comment on attachment 231743 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review > Source/WebKit2/ChangeLog:3 > + WebKit2/iOS: view is not visible if app is not foreground. Please update from the bugzilla. Is there a relevant radar? > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111 > bool PageClientImpl::isViewWindowActive() isViewsWindowActive? > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114 > + return isViewVisible(); Not clear what the implications of isViewWindowActive are. (In reply to comment #2) > (From update of attachment 231743 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review > > > Source/WebKit2/ChangeLog:3 > > + WebKit2/iOS: view is not visible if app is not foreground. > > Please update from the bugzilla. fixed > Is there a relevant radar? fixed > > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111 > > bool PageClientImpl::isViewWindowActive() > > isViewsWindowActive? I'll follow up in a separate change (per our discussion I'll probably remove outright). > > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114 > > + return isViewVisible(); > > Not clear what the implications of isViewWindowActive are. Agreed! - filed https://bugs.webkit.org/show_bug.cgi?id=133098 to track this. Transmitting file data ... Committed revision 169095. |