Bug 132580 – [WIN] Enhance auto-version.sh to handle all-caps or mixed-case build environment variable

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

In Bug 132455, I modified our build scripts to support mixed-case environment variables. However, we should still support older build machines running old versions of Cygwin where these variables will be set to all caps.

This patch assumes we will be using the new mixed-case variable style. If that variable is not present, it falls back to the original use of all capitals.

[Brent Fulgham]

Created attachment 230853 [details]
Patch

[Brent Fulgham]

<rdar://problem/16811179>

[Mark Rowe (bdash)]

Comment on attachment 230853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230853&action=review

> WebKitLibraries/win/tools/scripts/auto-version.sh:53
>  ENVIRONMENT_VERSION="$RC_ProjectSourceVersion";
> +if [[ -z "$ENVIRONMENT_VERSION" ]]; then
> +    # Try the original all-caps version of the environment variable
> +    ENVIRONMENT_VERSION="$RC_PROJECTSOURCEVERSION";
> +fi

You can avoid the if by doing something like:
ENVIRONMENT_VERSION=${RC_ProjectSourceVersion:-$RC_PROJECTSOURCEVERSION};

[Dean Jackson]

Comment on attachment 230853 [details]
Patch

Listen to Mark :)

[Brent Fulgham]

Committed r168321: <http://trac.webkit.org/changeset/168321>