RESOLVED FIXED 132580
[WIN] Enhance auto-version.sh to handle all-caps or mixed-case build environment variable 
https://bugs.webkit.org/show_bug.cgi?id=132580
Summary [WIN] Enhance auto-version.sh to handle all-caps or mixed-case build environm...
Brent Fulgham
Reported 2014-05-05 13:29:06 PDT
In Bug 132455, I modified our build scripts to support mixed-case environment variables. However, we should still support older build machines running old versions of Cygwin where these variables will be set to all caps. This patch assumes we will be using the new mixed-case variable style. If that variable is not present, it falls back to the original use of all capitals.
Attachments
Patch (1.50 KB, patch)
2014-05-05 13:31 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-05-05 13:31:02 PDT
Created attachment 230853 [details] Patch
Brent Fulgham
Comment 2 2014-05-05 13:31:26 PDT
<rdar://problem/16811179>
Mark Rowe (bdash)
Comment 3 2014-05-05 14:41:48 PDT
Comment on attachment 230853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230853&action=review > WebKitLibraries/win/tools/scripts/auto-version.sh:53 > ENVIRONMENT_VERSION="$RC_ProjectSourceVersion"; > +if [[ -z "$ENVIRONMENT_VERSION" ]]; then > + # Try the original all-caps version of the environment variable > + ENVIRONMENT_VERSION="$RC_PROJECTSOURCEVERSION"; > +fi You can avoid the if by doing something like: ENVIRONMENT_VERSION=${RC_ProjectSourceVersion:-$RC_PROJECTSOURCEVERSION};
Dean Jackson
Comment 4 2014-05-05 15:08:27 PDT
Comment on attachment 230853 [details] Patch Listen to Mark :)
Brent Fulgham
Comment 5 2014-05-05 15:12:29 PDT
Committed r168321: <http://trac.webkit.org/changeset/168321>
Note You need to log in before you can comment on or make changes to this bug.