Bug 132097

Summary: [iOS WK2] Make -webkit-overflow-scrolling:touch work
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Severity: Normal CC: benjamin, commit-queue, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2014-04-23 19:02:05 PDT
[iOS WK2] Make -webkit-overflow-scrolling:touch work
Comment 1 Simon Fraser (smfr) 2014-04-23 19:09:43 PDT
Created attachment 230031 [details]
Comment 2 Simon Fraser (smfr) 2014-04-23 19:11:09 PDT
Comment 3 WebKit Commit Bot 2014-04-23 19:11:12 PDT
Attachment 230031 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:58:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-04-23 19:23:59 PDT
Comment on attachment 230031 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=230031&action=review

> Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:57
> +    __block UIView* foundView = nil;

star on the wrong side

> Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:64
> +        if ([view subviews]) {

early return?
Comment 5 Simon Fraser (smfr) 2014-04-23 19:47:24 PDT
*** Bug 132015 has been marked as a duplicate of this bug. ***
Comment 6 Simon Fraser (smfr) 2014-04-23 20:32:44 PDT