Bug 132097 - [iOS WK2] Make -webkit-overflow-scrolling:touch work
Summary: [iOS WK2] Make -webkit-overflow-scrolling:touch work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 132015 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-23 19:02 PDT by Simon Fraser (smfr)
Modified: 2014-04-23 20:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.33 KB, patch)
2014-04-23 19:09 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-04-23 19:02:05 PDT 
[iOS WK2] Make -webkit-overflow-scrolling:touch work
Comment 1 Simon Fraser (smfr) 2014-04-23 19:09:43 PDT 
Created attachment 230031 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-04-23 19:11:09 PDT 
<rdar://problem/16655349>
Comment 3 WebKit Commit Bot 2014-04-23 19:11:12 PDT 
Attachment 230031 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:58:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2014-04-23 19:23:59 PDT 
Comment on attachment 230031 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230031&action=review

> Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:57
> +    __block UIView* foundView = nil;

star on the wrong side

> Source/WebKit2/UIProcess/ios/RemoteLayerTreeHostIOS.mm:64
> +        if ([view subviews]) {

early return?
Comment 5 Simon Fraser (smfr) 2014-04-23 19:47:24 PDT 
*** Bug 132015 has been marked as a duplicate of this bug. ***
Comment 6 Simon Fraser (smfr) 2014-04-23 20:32:44 PDT 
http://trac.webkit.org/changeset/167740