Bug 132081

Summary: [New Multicolumn] fast/multicol/hit-test-* layout tests all fail
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 131825    
Attachments:
Description Flags
Patch dino: review+

Description Dave Hyatt 2014-04-23 14:51:38 PDT
All four of the hit-test-* layout tests fail. Could just be pixel differences, but might be actual bugs here.
Comment 1 Dave Hyatt 2014-04-25 10:38:09 PDT
I think this boils down to positionForPoint on RenderMultiColumnSet needing to work with logical coordinates instead of treating the point passed in as physical.
Comment 2 Dave Hyatt 2014-04-25 13:02:19 PDT
Created attachment 230193 [details]
Patch
Comment 3 Dean Jackson 2014-04-25 13:19:41 PDT
Comment on attachment 230193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230193&action=review

> LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html:31
> +            log ("Character at " + x + ", " + y + " is " + character + " as expected.");
> +        else
> +            log ("FAIL: Character at " + x + ", " + y + " is " + actualCharacter + ". Expected " + character + ".");

Nit: extra space after log
Comment 4 Dave Hyatt 2014-04-25 13:21:20 PDT
Fixed in r167817.