Bug 132080

Summary: [New Multicolumn] Add support for offsetTop and offsetLeft
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141496    
Bug Blocks: 131825    
Attachments:
Description Flags
Patch
none
Patch abucur: review+

Dave Hyatt
Reported 2014-04-23 14:50:34 PDT
fast/multicol/break-after-always-bottom-margin-actual.html fails. Might just be that the test needs to be changed.
Attachments
Patch (77.33 KB, patch)
2014-04-24 21:16 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (76.38 KB, patch)
2014-04-24 21:19 PDT, Dave Hyatt 		abucur: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2014-04-23 20:41:56 PDT
This is because offsetTop is not implemented correctly for new columns. Pretty simple to fix.
Dave Hyatt
Comment 2 2014-04-24 21:16:51 PDT
Created attachment 230134 [details] Patch
Dave Hyatt
Comment 3 2014-04-24 21:19:31 PDT
Created attachment 230135 [details] Patch
Dave Hyatt
Comment 4 2014-04-24 21:26:06 PDT
(In reply to comment #1) > This is because offsetTop is not implemented correctly for new columns. Pretty simple to fix. "Pretty simple to fix." *Grumbles at yesterday me.*
Andrei Bucur
Comment 5 2014-04-24 23:10:54 PDT
Comment on attachment 230135 [details] Patch r=me
Dave Hyatt
Comment 6 2014-04-25 09:22:13 PDT
Landed in r167808.
Note You need to log in before you can comment on or make changes to this bug.