Bug 132080

Summary:

[New Multicolumn] Add support for offsetTop and offsetLeft

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

141496

Bug Blocks:

131825

Attachments:

Description	Flags
Patch	none
Patch	abucur: review+

Description Dave Hyatt 2014-04-23 14:50:34 PDT

fast/multicol/break-after-always-bottom-margin-actual.html fails. Might just be that the test needs to be changed.

Comment 1 Dave Hyatt 2014-04-23 20:41:56 PDT

This is because offsetTop is not implemented correctly for new columns. Pretty simple to fix.

Comment 2 Dave Hyatt 2014-04-24 21:16:51 PDT

Created attachment 230134 [details]
Patch

Comment 3 Dave Hyatt 2014-04-24 21:19:31 PDT

Created attachment 230135 [details]
Patch

Comment 4 Dave Hyatt 2014-04-24 21:26:06 PDT

(In reply to comment #1)
> This is because offsetTop is not implemented correctly for new columns. Pretty simple to fix.

"Pretty simple to fix." *Grumbles at yesterday me.*

Comment 5 Andrei Bucur 2014-04-24 23:10:54 PDT

Comment on attachment 230135 [details]
Patch

r=me

Comment 6 Dave Hyatt 2014-04-25 09:22:13 PDT

Landed in r167808.