Bug 131986

Summary: Refactoring editing/selection/13804.html
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: HTML EditingAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, gyuyoung.kim, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 125689    
Attachments:
Description Flags
Patch
darin: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 none

Grzegorz Czajkowski
Reported 2014-04-22 07:29:02 PDT
This test does not need pixel baselines (MAC, EFL, GTK) to just check whether or not spelling marker appears on 'adf'. According to bug 125688, the test started using asynchronous spellchecking. Since the test mostly verifies spelling behaviour, it was moved to editing/spelling directory. Its name was changed to spelling-backward.html.
Attachments
Patch (55.03 KB, patch)
2014-04-22 07:32 PDT, Grzegorz Czajkowski 		darin: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (457.80 KB, application/zip)
2014-04-22 11:25 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2014-04-22 07:32:07 PDT
Created attachment 229881 [details] Patch
Build Bot
Comment 2 2014-04-22 11:25:16 PDT
Comment on attachment 229881 [details] Patch Attachment 229881 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5697014557835264 New failing tests: editing/spelling/spelling-backward.html
Build Bot
Comment 3 2014-04-22 11:25:20 PDT
Created attachment 229900 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Grzegorz Czajkowski
Comment 4 2014-04-22 12:02:25 PDT
(In reply to comment #2) > (From update of attachment 229881 [details]) > Attachment 229881 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/5697014557835264 > > New failing tests: > editing/spelling/spelling-backward.html Needs to be marked as failure due to bug 125690. I will fix that before landing.
Grzegorz Czajkowski
Comment 5 2014-04-23 00:34:58 PDT
Committed r167701: <http://trac.webkit.org/changeset/167701>
Note You need to log in before you can comment on or make changes to this bug.