| Summary: | Fix Mac build so that bindings generators are not run every build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||
| Component: | Bindings | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | CC: | simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Bem Jones-Bey
2014-04-17 15:01:32 PDT
Created attachment 229580 [details]
Patch
Once this has been reviewed, I will file bugs for the other ports, so their maintainers can do something similar. Created attachment 229585 [details]
Patch
Fix a couple things I missed on the first version
I think it would be better to always generate the output file if the IDL file timestamp is newer (just like other dependencies). (In reply to comment #4) > I think it would be better to always generate the output file if the IDL file timestamp is newer (just like other dependencies). That pretty much means reverting the patch for Bug 131756. I'm OK with that if that isn't the right fix for the problem. The original problem was that it happens that the IDL file gets updated but it hasn't actually changed in a way that causes the generated files to be different, but since they got touched by the generators, they ended up getting recompiled anyways. Comment on attachment 229585 [details]
Patch
Let's roll out the previous patch, and if we think we can touch generated files less but keep them more recent than the IDL files, do that.
Rolled out the fix for Bug 131756. So this isn't needed. |