Bug 131808

Summary: [New Multicolumn] fast/multicol/multicol-with-child-renderLayer-for-input.html puts the textfield in the wrong place
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, mstensho, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 131825    
Attachments:
Description Flags
Test case
none
Patch
hyatt: review-
Patch beidson: review+

Dave Hyatt
Reported 2014-04-17 13:37:34 PDT
The layer is in the wrong place. Forcing a new layout snaps it to the right place, so it's some problem where the layer position is initially incorrect (or only the widget position is incorrect and it syncs to the layer later).
Attachments
Test case (815 bytes, text/html)
2014-04-22 07:26 PDT, Morten Stenshorne 		no flags
Details
Patch (5.61 KB, patch)
2014-04-22 07:28 PDT, Morten Stenshorne 		hyatt: review-
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2014-04-22 09:02 PDT, Dave Hyatt 		beidson: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-04-17 23:12:43 PDT
<rdar://problem/16656286>
Dave Hyatt
Comment 2 2014-04-21 13:44:03 PDT
This is a blocker for turning the new columns on.
Morten Stenshorne
Comment 3 2014-04-22 07:25:48 PDT
*** Bug 131984 has been marked as a duplicate of this bug. ***
Morten Stenshorne
Comment 4 2014-04-22 07:26:43 PDT
Created attachment 229879 [details] Test case
Morten Stenshorne
Comment 5 2014-04-22 07:28:39 PDT
Created attachment 229880 [details] Patch
Dave Hyatt
Comment 6 2014-04-22 08:52:46 PDT
Comment on attachment 229880 [details] Patch Your fix is basically just working around the fact that the flags were wrong. This is because some code is missing from FrameView. It's patched for the old columns but not for the new ones. I'll post a revised patch with your test case in a bit.
Dave Hyatt
Comment 7 2014-04-22 09:02:01 PDT
Created attachment 229884 [details] Patch
Dave Hyatt
Comment 8 2014-04-22 09:08:50 PDT
Fixed in r167663.
Note You need to log in before you can comment on or make changes to this bug.