Bug 131563

Summary: [iOS WebKit2] Expose a simplified zoom-to-rect to the WebProcess
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, commit-queue, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 131510    
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2014-04-11 14:51:35 PDT
Add a simple message that calls WKContentView's zoom-to-rect code given just a rect and min/max scale.
Attachments
patch (6.56 KB, patch)
2014-04-11 14:53 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-04-11 14:53:00 PDT
Created attachment 229163 [details] patch
WebKit Commit Bot
Comment 2 2014-04-11 14:54:51 PDT
Attachment 229163 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:610: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/PageClient.h:252: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/ios/PageClientImplIOS.h:125: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2014-04-11 14:55:53 PDT
http://trac.webkit.org/changeset/167154
Tim Horton
Comment 4 2014-04-11 14:57:31 PDT
And http://trac.webkit.org/changeset/167155 for the stylebot.
Tim Horton
Comment 5 2017-03-07 23:34:28 PST
Why did I do this? Nothing calls it?
Note You need to log in before you can comment on or make changes to this bug.