| Summary: | Support document-relative and custom-frame page overlays | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | WebKit2 | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | adele, alice.barraclough, commit-queue, esprehn+autocc, glenn, kondapallykalyan, sam, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 131510 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2014-04-11 13:41:12 PDT
Created attachment 229160 [details]
patch
Created attachment 229161 [details]
patch
Attachment 229161 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderLayerCompositor.h:307: The parameter name "documentOverlayRootLayer" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebKit2/WebProcess/WebPage/PageOverlay.h:95: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 2 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 229161 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=229161&action=review > Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp:104 > + if (overlay->overlayType() == PageOverlay::OverlayType::View) { > + if (Page* page = m_webPage->corePage()) { > + if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator()) > + scrollingCoordinator->setForceSynchronousScrollLayerPositionUpdates(true); > + } Why not just call updateForceSynchronousScrollLayerPositionUpdates()? > Source/WebKit2/WebProcess/WebPage/PageOverlayController.h:38 > +namespace WebCore { > +class Frame; > +} Remove. You just use WebCore::Frame below. |