| Summary: | check-webkit-style should skip in-tree bindings tests results | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | llango.u-szeged, ossy, pmolnar.u-szeged |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Brian Burg
2014-04-11 12:33:50 PDT
I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py (In reply to comment #1) > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py Yes, it can works. But I prefer fixing the generator instead of disabling style checker for these files. I don't like 5-space indentation. :-/ (In reply to comment #2) > (In reply to comment #1) > > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py > > Yes, it can works. But I prefer fixing the generator > instead of disabling style checker for these files. > > I don't like 5-space indentation. :-/ The bug isn't in check-webkit-style, but the change in code generator which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > I think it just needs to include these paths in _SKIPPED_FILES_WITHOUT_WARNING of checker.py > > > > Yes, it can works. But I prefer fixing the generator > > instead of disabling style checker for these files. > > > > I don't like 5-space indentation. :-/ > > The bug isn't in check-webkit-style, but the change in code generator > which added 5-space indentation accidentally: https://trac.webkit.org/changeset/165521 Created a fix for the code generator: https://bugs.webkit.org/show_bug.cgi?id=131613 Oops, I guess it was my fault all along. Thanks everyone. |