Bug 131411

Summary: Remove "System Font" from char width calculations
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 131479    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2014-04-08 17:45:31 PDT
Remove "System Font" from whitelisted DRT fonts and char width calculations
Attachments
Patch (2.66 KB, patch)
2014-04-08 17:50 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.48 KB, patch)
2014-04-10 12:04 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-04-08 17:50:13 PDT
Created attachment 228922 [details] Patch
Myles C. Maxfield
Comment 2 2014-04-08 17:51:51 PDT
<rdar://problem/16281488>
WebKit Commit Bot
Comment 3 2014-04-09 15:03:40 PDT
Comment on attachment 228922 [details] Patch Rejecting attachment 228922 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 228922, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5926285901561856
Myles C. Maxfield
Comment 4 2014-04-09 15:55:36 PDT
http://trac.webkit.org/changeset/167046
Alexey Proskuryakov
Comment 5 2014-04-09 23:29:52 PDT
This change caused 300+ failures on Mountain Lion WK1 tester: <http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r167064%20(5110)/results.html>. Rolling out.
Myles C. Maxfield
Comment 6 2014-04-10 10:18:55 PDT
And yet EWS is all green? I am very surprised by this.
Tim Horton
Comment 7 2014-04-10 11:02:04 PDT
(In reply to comment #6) > And yet EWS is all green? I am very surprised by this. EWS uses Mountain Lion.
Myles C. Maxfield
Comment 8 2014-04-10 11:30:40 PDT
I have figured out what happened. There are two ways that the system font gets whitelisted in DRT, and this patch removes one and http://trac.webkit.org/changeset/167043 removes the other. This patch looks like the culprit because it was committed last. In my testing I hadn't tested the two patches on top of each other; only one after the other.
Myles C. Maxfield
Comment 9 2014-04-10 12:04:56 PDT
Created attachment 229064 [details] Patch
WebKit Commit Bot
Comment 10 2014-04-10 12:17:21 PDT
Comment on attachment 229064 [details] Patch Clearing flags on attachment: 229064 Committed r167082: <http://trac.webkit.org/changeset/167082>
WebKit Commit Bot
Comment 11 2014-04-10 12:17:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.