Summary: | Web Replay: CodeGeneratorJS should guard includes of replay-related headers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||
Component: | Bindings | Assignee: | Brian Burg <burg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, cdumez, cgarcia, commit-queue, esprehn+autocc, joepeck, kling, kondapallykalyan, sam, timothy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 131340 | ||||||
Attachments: |
|
Description
Brian Burg
2014-04-08 16:25:03 PDT
Created attachment 228917 [details]
the patch
Attachment 228917 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.h:118: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:174: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:276: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:278: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:312: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:314: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:429: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:457: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 13 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Anders, does NeverDestroyed play nice with AtomicString? (In reply to comment #3) > Anders, does NeverDestroyed play nice with AtomicString? There are ~15 uses of NeverDestroyed<const AtomicString> in the codebase and ~90 uses of NeverDestroyed<AtomicString>. So, if it is an anti-pattern, there's some more cleanup to do. Comment on attachment 228917 [details]
the patch
Patch looks good to me.
Comment on attachment 228917 [details] the patch Clearing flags on attachment: 228917 Committed r167140: <http://trac.webkit.org/changeset/167140> All reviewed patches have been landed. Closing bug. |