Bug 131340

Summary: Web Replay: memoize nondeterministic attributes of the Navigator interface
Product: WebKit Reporter: Brian Burg <burg>
Component: BindingsAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, joepeck, kling, kondapallykalyan, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 131407    
Bug Blocks:    
Attachments:
Description Flags
the patchb none

Brian Burg
Reported 2014-04-07 18:51:26 PDT
These are easy to memoize, and this is a good layer to handle them at since different ports can do different things. navigator.plugins and navigator.mimeTypes will be handled separately, since we can memoize the underlying call to Page::pluginData().
Attachments
the patchb (7.65 KB, patch)
2014-04-08 17:37 PDT, Brian Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2014-04-08 17:33:09 PDT
This depends on code generator fix in 131407, but I'll upload the patch now anyway.
Brian Burg
Comment 2 2014-04-08 17:37:30 PDT
Created attachment 228920 [details] the patchb
WebKit Commit Bot
Comment 3 2014-04-11 15:01:33 PDT
Comment on attachment 228920 [details] the patchb Clearing flags on attachment: 228920 Committed r167157: <http://trac.webkit.org/changeset/167157>
WebKit Commit Bot
Comment 4 2014-04-11 15:01:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.