Summary: | Honor System-Level User Preferences for Captions Display | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, jonlee, philipj, sergio | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 131344 | ||||||
Attachments: |
|
Description
Brent Fulgham
2014-04-04 21:15:06 PDT
Created attachment 228653 [details]
Patch
Comment on attachment 228653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228653&action=review > Source/WebCore/html/HTMLMediaElement.cpp:-3713 > - m_captionDisplayMode = displayMode; I needed to do this so that the "ForceOn" state was properly seen by system. All tests (including uncommitted region tests) pass with this change. (In reply to comment #4) > All tests (including uncommitted region tests) pass with this change. Additional test case, then? (In reply to comment #5) > (In reply to comment #4) > > All tests (including uncommitted region tests) pass with this change. > > Additional test case, then? after looking at it, I realize it's just a local copy of one of the Opera tests. I'm trying to get the whole set of them turned on in an upcoming patch. Committed r166858: <http://trac.webkit.org/changeset/166858> |