Bug 131194

Summary: [Win] Load Media Controls js/css from bundle
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 131086    
Bug Blocks:    
Attachments:
Description Flags
Patch dino: review+

Brent Fulgham
Reported 2014-04-03 17:03:37 PDT
We can load the mediaControls*.{js,css} files from the bundle, rather than inserting encoding versions into the C source code on Windows, just like we can for Mac/iOS.
Attachments
Patch (24.57 KB, patch)
2014-04-03 22:11 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-04-03 22:11:12 PDT
Created attachment 228578 [details] Patch
Dean Jackson
Comment 2 2014-04-03 22:17:09 PDT
Comment on attachment 228578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:7092 > + <ClCompile Include="..\platform\DisplaySleepDisabler.cpp" /> > + <ClCompile Include="..\platform\SystemSleepListener.cpp" /> There are a lot of changes to this file, but I assume it's either unintentional and you'll remove it, or intentional and you know what you are doing! > Source/WebCore/rendering/RenderThemeSafari.h:188 > + bool m_mediaControlsScriptLoaded; > + bool m_mediaControlsStyleSheetLoaded; There was a followup commit where I skipped the booleans and just checked if the string was empty. > Source/WebCore/rendering/RenderThemeWin.cpp:1117 > + // Open the file Nit: end with .
Brent Fulgham
Comment 3 2014-04-04 09:08:14 PDT
Comment on attachment 228578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review >> Source/WebCore/rendering/RenderThemeWin.cpp:1117 >> + // Open the file > > Nit: end with . Even better -- why have this stupid comment at all!?! :-)
Brent Fulgham
Comment 4 2014-04-04 09:08:22 PDT
Comment on attachment 228578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review >> Source/WebCore/rendering/RenderThemeWin.cpp:1117 >> + // Open the file > > Nit: end with . Even better -- why have this stupid comment at all!?! :-)
Brent Fulgham
Comment 5 2014-04-04 09:13:05 PDT
Committed r166782: <http://trac.webkit.org/changeset/166782>
Note You need to log in before you can comment on or make changes to this bug.