Summary: | [Win] Load Media Controls js/css from bundle | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dino, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Bug Depends on: | 131086 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Brent Fulgham
2014-04-03 17:03:37 PDT
Created attachment 228578 [details]
Patch
Comment on attachment 228578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:7092 > + <ClCompile Include="..\platform\DisplaySleepDisabler.cpp" /> > + <ClCompile Include="..\platform\SystemSleepListener.cpp" /> There are a lot of changes to this file, but I assume it's either unintentional and you'll remove it, or intentional and you know what you are doing! > Source/WebCore/rendering/RenderThemeSafari.h:188 > + bool m_mediaControlsScriptLoaded; > + bool m_mediaControlsStyleSheetLoaded; There was a followup commit where I skipped the booleans and just checked if the string was empty. > Source/WebCore/rendering/RenderThemeWin.cpp:1117 > + // Open the file Nit: end with . Comment on attachment 228578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review >> Source/WebCore/rendering/RenderThemeWin.cpp:1117 >> + // Open the file > > Nit: end with . Even better -- why have this stupid comment at all!?! :-) Comment on attachment 228578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228578&action=review >> Source/WebCore/rendering/RenderThemeWin.cpp:1117 >> + // Open the file > > Nit: end with . Even better -- why have this stupid comment at all!?! :-) Committed r166782: <http://trac.webkit.org/changeset/166782> |