| Summary: | Web Inspector: add entries for probe samples in the JS/Events timeline UI | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||||||
| Component: | Web Inspector | Assignee: | Katie Madonna <madonnk> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | 131127 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Brian Burg
2014-04-03 11:09:44 PDT
Created attachment 229595 [details]
ProbeSampleFired events in the main timeline view.
Created attachment 229596 [details]
ProbeSampleFired event selected view.
Created attachment 229597 [details]
Patch
Comment on attachment 229597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229597&action=review Looking good. Missing the icon file. > Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:218 > + return WebInspector.UIString("Probe Sample Fired"); I think “Probe Sample Recorded” or “Probe Fired” would be better. > Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css:79 > + content: url(../Images/TimelineRecordProbeSampled.svg); I don't see the icon added in the patch. Forget svn/git add? Created attachment 229672 [details]
Patch
Comment on attachment 229672 [details]
Patch
Looks good!
Comment on attachment 229672 [details] Patch Clearing flags on attachment: 229672 Committed r167509: <http://trac.webkit.org/changeset/167509> All reviewed patches have been landed. Closing bug. |