Bug 131173

Summary: Web Inspector: add entries for probe samples in the JS/Events timeline UI
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Katie Madonna <madonnk>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 131127    
Bug Blocks:    
Attachments:
Description Flags
ProbeSampleFired events in the main timeline view.
none
ProbeSampleFired event selected view.
none
Patch
none
Patch none

Brian Burg
Reported 2014-04-03 11:09:44 PDT
UI work for 131127.
Attachments
ProbeSampleFired events in the main timeline view. (80.13 KB, image/png)
2014-04-17 16:47 PDT, Katie Madonna 		no flags
Details
ProbeSampleFired event selected view. (289.01 KB, image/png)
2014-04-17 16:48 PDT, Katie Madonna 		no flags
Details
Patch (7.29 KB, patch)
2014-04-17 16:50 PDT, Katie Madonna 		no flags
DetailsFormatted DiffDiff
Patch (10.43 KB, patch)
2014-04-18 13:41 PDT, Katie Madonna 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-04-03 11:10:18 PDT
<rdar://problem/16514032>
Radar WebKit Bug Importer
Comment 2 2014-04-03 11:10:23 PDT
<rdar://problem/16514035>
Katie Madonna
Comment 3 2014-04-17 16:47:24 PDT
Created attachment 229595 [details] ProbeSampleFired events in the main timeline view.
Katie Madonna
Comment 4 2014-04-17 16:48:03 PDT
Created attachment 229596 [details] ProbeSampleFired event selected view.
Katie Madonna
Comment 5 2014-04-17 16:50:36 PDT
Created attachment 229597 [details] Patch
Timothy Hatcher
Comment 6 2014-04-17 17:38:16 PDT
Comment on attachment 229597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229597&action=review Looking good. Missing the icon file. > Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:218 > + return WebInspector.UIString("Probe Sample Fired"); I think “Probe Sample Recorded” or “Probe Fired” would be better. > Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css:79 > + content: url(../Images/TimelineRecordProbeSampled.svg); I don't see the icon added in the patch. Forget svn/git add?
Katie Madonna
Comment 7 2014-04-18 13:41:13 PDT
Created attachment 229672 [details] Patch
Timothy Hatcher
Comment 8 2014-04-18 13:44:47 PDT
Comment on attachment 229672 [details] Patch Looks good!
WebKit Commit Bot
Comment 9 2014-04-18 14:22:07 PDT
Comment on attachment 229672 [details] Patch Clearing flags on attachment: 229672 Committed r167509: <http://trac.webkit.org/changeset/167509>
WebKit Commit Bot
Comment 10 2014-04-18 14:22:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.