Bug 131127

Summary:

Web Inspector: hook up probe samples to TimelineAgent's records

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, madonnk, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

131173

Attachments:

Description	Flags
the patch	timothy: review+

Description Brian Burg 2014-04-02 14:01:09 PDT

Katie and I are unsure whether to put probes+console messages into its own timeline category, or to fold it into the JavaScript & Events category. Our first step is to prototype the latter to see how it would work.

Comment 1 Radar WebKit Bug Importer 2014-04-02 14:02:06 PDT

<rdar://problem/16503719>

Comment 2 Brian Burg 2014-04-03 11:09:57 PDT

Narrowing this bug just to hooking up the backend. Katie will tackle the frontend part.

Comment 3 Brian Burg 2014-04-03 18:13:46 PDT

Created attachment 228568 [details]
the patch

Comment 4 Timothy Hatcher 2014-04-04 12:29:07 PDT

Comment on attachment 228568 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228568&action=review

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:275
> +            case TimelineAgent.EventType.ProbeSample:
> +                break;

FIXME comment here would be nice.

Comment 5 Brian Burg 2014-04-04 22:54:16 PDT

Committed r166827: <http://trac.webkit.org/changeset/166827>